Project

General

Profile

Bug #24686

VNC - Small cursor offset due to outer UI

Added by Arend Lapere almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Arend Lapere
Category:
Compute resources
Target version:
-
Difficulty:
trivial
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/5991, https://github.com/theforeman/foreman/pull/5979
Fixed in Releases:
1.19.0
Found in Releases:
1.18.1, 1.19.0-RC2

Description

I noticed, while using VNC that a small offset is noticable while doing mouse interactions.
The easiest way to reproduce this, is to go the desktop of your OS and do a right mouse button click. Usually, a context-menu pops up. However, it is offseted by 10px from the top and 10px from the left.

After investigation, the rounder border box seems to be the culprit. Disabling this solves the offset issue (and IMHO looks a bit more modern even)

Before.png View Before.png 88.8 KB Before Arend Lapere, 08/22/2018 12:08 PM
After.png View After.png 224 KB After Arend Lapere, 08/22/2018 12:08 PM
no-offset.png View no-offset.png 25.9 KB No Offset Arend Lapere, 08/22/2018 12:09 PM
offset.png View offset.png 26.8 KB Offset Arend Lapere, 08/22/2018 12:09 PM
Before After No offset Offset

Associated revisions

Revision fa515db6 (diff)
Added by UXabre almost 2 years ago

Fixes #24686 - Remove border around console to fix cursor offset

History

#1 Updated by Arend Lapere almost 2 years ago

  • Description updated (diff)
  • File screencapture-foreman-darwin-cloudbase-televic-4443-hosts-tommy-swantner-cloudbase-televic-com-console-2018-08-22-13_45_03.png added
  • File screencapture-10-1-213-109-5000-hosts-tommy-swantner-cloudbase-televic-com-console-2018-08-22-13_43_50.png added

I've managed to solve the issue and also clean up the UI a bit. I Hope you like the end-result as well. Looks a bit more in-line with the rest of the new UI.

Before:

After:

#2 Updated by Arend Lapere almost 2 years ago

  • File deleted (screencapture-foreman-darwin-cloudbase-televic-4443-hosts-tommy-swantner-cloudbase-televic-com-console-2018-08-22-13_45_03.png)
  • File deleted (screencapture-10-1-213-109-5000-hosts-tommy-swantner-cloudbase-televic-com-console-2018-08-22-13_43_50.png)
  • File deleted (2018-08-22 13_47_25-tommy-swantner.cloudbase.televic.com.png)
  • File deleted (2018-08-22 13_46_58-tommy-swantner.cloudbase.televic.com.png)
  • File offset.png offset.png added
  • File no-offset.png no-offset.png added
  • File After.png After.png added
  • File Before.png Before.png added

#3 Updated by Arend Lapere almost 2 years ago

  • Description updated (diff)

#4 Updated by Arend Lapere almost 2 years ago

  • Category set to Compute resources

#5 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5979 added

#6 Updated by Tomer Brisker almost 2 years ago

  • Assignee set to Arend Lapere
  • Fixed in Releases 1.20.0 added

#7 Updated by Anonymous almost 2 years ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/5991 added

#9 Updated by Tomer Brisker almost 2 years ago

  • Fixed in Releases 1.19.0 added

Also available in: Atom PDF