Project

General

Profile

Bug #24691

Virtual interfaces are incorrectly updated from puppet facts when using facter 3.0 and above

Added by Herwig Bogaert 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Category:
Network
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Unless the setting 'Ignore Puppet facts for provisioning' is set to 'Yes', foreman updates the hosts interface information based on Puppet facts. With facter version >= 3.0, a virtual interface is currently incorrectly
classified as being physical and its name overwrites the name of the physical interface to which it is attached in the foreman database.

Foreman parses the interface name in order to distinguish between physical andvirtual interfaces. For virtual interfaces, this feature currently only works correctly with facter versions < 3.0 because it relies on:

Related issues

Related to Foreman - Bug #24073: Foreman fact parser unable to process NPAR NICs with underscoreNew2018-06-26

Associated revisions

Revision 911e1097 (diff)
Added by Herwig Bogaert 4 months ago

Fixes #24691 - interfaces are incorrectly updated

Corrects virtual interfaces facts parsing when running facter > v3.0.
- facter >= v3.0 no longer replaces the . (dot) and : (colon) in the
interface name with an _ (underscore)
- the 'vlans' fact has been removed in facter >= v3.0

The fix does not alter the behavior when running facter < v3.0.

History

#1 Updated by Herwig Bogaert 4 months ago

  • Description updated (diff)

#2 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5984 added

#3 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman/pull/5985 added

#4 Updated by Lukas Zapletal 4 months ago

  • Related to Bug #24073: Foreman fact parser unable to process NPAR NICs with underscore added

#5 Updated by Lukas Zapletal 4 months ago

  • Fixed in Releases 1.20.0 added
  • Pull request deleted (https://github.com/theforeman/foreman/pull/5984)

#6 Updated by Herwig Bogaert 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF