Bug #24694: Report rendering can fail when log source is nil - Ansible - Foreman

Actions

Copy link

Bug #24694

closed

Report rendering can fail when log source is nil

Added by Marek Hulán over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman_ansible/pull/201

Fixed in Releases:

foreman-ansible 2.3.0

Found in Releases:

Red Hat JIRA:

Description

source being nil is valid also for puppet reports which simply print empty cell

2018-08-23T08:20:37 [E|app|6742e] <NoMethodError> undefined method `value' for nil:NilClass
        /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-2.2.5/app/helpers/foreman_ansible/ansible_reports_helper.rb:89:in `parsed_message_json'
        /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-2.2.5/app/helpers/foreman_ansible/ansible_reports_helper.rb:21:in `ansible_module_args'
        /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-2.2.5/app/views/foreman_ansible/config_reports/_ansible.html.erb:18:in `block in _b5e9bde58eab8d1c2202e8e759f132ee'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activerecord-5.1.6/lib/active_record/relation/delegation.rb:39:in `each'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activerecord-5.1.6/lib/active_record/relation/delegation.rb:39:in `each'
        /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_ansible-2.2.5/app/views/foreman_ansible/config_reports/_ansible.html.erb:14:in `_b5e9bde58eab8d1c2202e8e759f132ee'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:157:in `block in render'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:168:in `instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:352:in `instrument_render_template'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:155:in `render'
        /opt/theforeman/tfm/root/usr/share/gems/gems/deface-1.2.0/lib/deface/action_view_extensions.rb:41:in `render'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/partial_renderer.rb:342:in `block in render_partial'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:166:in `block in instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:166:in `instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/partial_renderer.rb:331:in `render_partial'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/partial_renderer.rb:310:in `render'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/renderer/renderer.rb:47:in `render_partial'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/helpers/rendering_helper.rb:35:in `render'
        /usr/share/foreman/app/views/config_reports/show.html.erb:16:in `_48a6b6050e420240bcdb286f7efd5bd7'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:157:in `block in render'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/activesupport-5.1.6/lib/active_support/notifications.rb:168:in `instrument'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:352:in `instrument_render_template'
        /opt/theforeman/tfm-ror51/root/usr/share/gems/gems/actionview-5.1.6/lib/action_view/template.rb:155:in `render'
        /opt/theforeman/tfm/root/usr/share/gems/gems/deface-1.2.0/lib/deface/action_view_extensions.rb:41:in `render