Actions
Bug #24763
closedAny error in CreateRssNotifications still marks the task as success and it doesn't re-schedule next event
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Description
How to reproduce:
1. simulate error during the rss notification (add raise 'error' to https://github.com/theforeman/foreman/blob/44539bfc73f1c36e57985707032a1c91160af799/app/jobs/create_rss_notifications.rb#L8)
2. restart the dynflowd (or web server in case of development)
3. notice that the "Create RSS notifications" (when foreman-tasks is present) in still in stopped/success
4. further notice, there is not next task planned for the next check
It turns out the active_job is not handling `after_perform` callback when rescue bock is triggered, see https://github.com/rails/rails/blob/v5.2.0/activejob/lib/active_job/execution.rb#L33-L43
Updated by Ivan Necas over 6 years ago
- Related to Bug #24761: Don't pause on active jobs tasks added
Updated by The Foreman Bot over 6 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6016 added
Updated by Ivan Necas over 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset f4f5e16e2fbe532ad26f0ebb1d4edf483752ed73.
Actions