Project

General

Profile

Actions

Bug #24810

closed

Missing value in product details causes values to not align to their labels

Added by Andrew Kofink over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Subscriptions
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1625175

On Subscription details page, there are 4 values displayed for each product: Content Download URL, GPG Key URL, Repo Type and Enabled?. If one value is missing, it causes subsequent values to shift up and not align with their labels. See attached screenshot.

Version-Release number of selected component (if applicable):
tfm-rubygem-katello-3.7.0

Steps to Reproduce:
1. Create new product. Make sure that GPG Key field remains empty. Add one yum repository: https://repos.fedorapeople.org/repos/pulp/pulp/demo_repos/zoo/
2. Content -> Subscriptions -> Product from previous step -> Enabled Products -> expand product
3. Try to read data

Solution:
The root cause is HTML structure displaying ultimately tabular data in column-oriented way instead of row-oriented way.

Instead of (simplified code):

<div class="col-sm-3">
<div class="row">Label</div>
</div>
<div class="col-sm-9">
<div class="row">value</div>
</div>

It should be:

<div class="row">
<div class="col-sm-3">
Label
</div>
<div class="col-sm-9">
value
</div>
</div>

New structure would also make data more readable on phones / very narrow screens. Right now it's all labels, all values, one under another. With new structure, it would be label, value, intertwined.

Actions #1

Updated by Tomáš Strachota over 5 years ago

  • Subject changed from Missing value in product details causes values to not align to their labels to Missing value in product details causes values to not align to their labels
  • Team Backlog UX added
Actions #2

Updated by Justin Sherrill over 5 years ago

  • Target version set to Katello 3.9.0
  • Triaged changed from No to Yes
Actions #3

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Amir Fefer
  • Pull request https://github.com/Katello/katello/pull/7680 added
Actions #4

Updated by Amir Fefer over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF