Project

General

Profile

Actions

Bug #24825

closed

Cleanup after unsucessful backup attempt is not 100% accurate with previously nonexistent destination

Added by Peter Ondrejka over 5 years ago. Updated 2 months ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

This is a minor issue happening when creating a backup in previously nonexistent directory, e.g.:

foreman-maintain backup online test
...
Check if the directory exists and is writable: [FAIL]
Postgres user needs write access to the backup directory
Please allow the postgres user write access to /root/test/satellite-backup-2018-09-05-07-19-14 or choose another directory.
...
Running Failed backup cleanup
Clean up backup directory: [OK]

However, only satellite-backup* is cleaned up, /root/test/ remains created.
On the other hand, doing the same with --preserve-directory:

foreman-maintain backup online --preserve-directory test2
...
Prepare backup Directory:
Creating backup folder /root/test2 [OK]
--------------------------------------------------------------------------------
Check if the directory exists and is writable: [FAIL]
Backup directory (/root/test2) does not exit.
--------------------------------------------------------------------------------
...
Running Failed backup cleanup
...
Clean up backup directory: [SKIPPED]
Backup directory will be preserved
--------------------------------------------------------------------------------

Here /root/test2 is not even created, despite the preservation message

Actions #1

Updated by Eric Helms 2 months ago

  • Status changed from New to Rejected
Actions

Also available in: Atom PDF