Bug #24850
closed
Do not allow usergroup to be added to itself
Description
When editing a usergroup, it is possible to add it to itself and cause endless method call loop.
Steps to reproduce:
1) create a usergroup
2) edit that usergroup and add it to selected items (see the screenshot), submit
3) stack level too deep
Files
Updated by Marek Hulán over 5 years ago
We used to have validation for that - https://github.com/theforeman/foreman/blob/ae96cb70130968bdcc8b7a9a9af7edc7c6e0d9a8/app/models/usergroup_member.rb#L25
Perhaps after some upgrade, before_validation stopped working?
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Ondřej Pražák
- Pull request https://github.com/theforeman/foreman/pull/6054 added
Updated by Ondřej Pražák over 5 years ago
Marek Hulán wrote:
We used to have validation for that - https://github.com/theforeman/foreman/blob/ae96cb70130968bdcc8b7a9a9af7edc7c6e0d9a8/app/models/usergroup_member.rb#L25
Perhaps after some upgrade, before_validation stopped working?
That one works and detects cycles as expected when I have B inside A and try to add A into B. But it ignores case when I try to add A into A.
Updated by Ondřej Pražák about 5 years ago
- Has duplicate Bug #26360: Adding current usergroup to them self cause error added
Updated by Ondřej Pražák about 5 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 37e90f727e40899bab3757f0d2e8993c96854ac4.
Updated by Tomer Brisker about 5 years ago
- Related to Bug #26575: Stack trace when adding/removing an user to a group added
Updated by Tomer Brisker about 5 years ago
- Related to deleted (Bug #26575: Stack trace when adding/removing an user to a group)
Updated by Tomer Brisker about 5 years ago
- Has duplicate Bug #26575: Stack trace when adding/removing an user to a group added
Updated by Tomer Brisker almost 4 years ago
- Category changed from 218 to Users, Roles and Permissions