Project

General

Profile

Refactor #25059

Rely on kafo's module_enabled hook

Added by Ewoud Kohl van Wijngaarden 12 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
foreman-installer script
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Currently there's a custom helper because the kafo hook is insufficient. It'd be nice to rely on pure kafo functionality.


Related issues

Blocked by Kafo - Feature #25058: Handle unknown modules in module_enabled? hook contextClosed

Associated revisions

Revision ff9143a4 (diff)
Added by Ewoud Kohl van Wijngaarden 5 months ago

Fixes #25059 - Remove local module_enabled? method

Until Kafo 3.0 its hook method didn't handle non-existing modules. Now
there's no more need for this additional check.

History

#1 Updated by Ewoud Kohl van Wijngaarden 12 months ago

  • Blocked by Feature #25058: Handle unknown modules in module_enabled? hook context added

#2 Updated by The Foreman Bot 12 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/Katello/katello-installer/pull/692 added

#3 Updated by Jonathon Turel 12 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.10.0

#4 Updated by Christine Fouant 10 months ago

  • Target version changed from Katello 3.10.0 to Katello 3.11.0

#5 Updated by Jonathon Turel 9 months ago

  • Target version changed from Katello 3.11.0 to Katello Backlog

#6 Updated by Ewoud Kohl van Wijngaarden 9 months ago

  • Target version changed from Katello Backlog to 1.22.0
  • Category changed from Installer to foreman-installer script
  • Project changed from Katello to Installer
  • Pull request deleted (https://github.com/Katello/katello-installer/pull/692)

#7 Updated by The Foreman Bot 5 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/342 added

#8 Updated by Michael Moll 5 months ago

  • Fixed in Releases 1.22.0 added

#9 Updated by Ewoud Kohl van Wijngaarden 5 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF