Refactor #25059
Rely on kafo's module_enabled hook
Status:
Closed
Priority:
Normal
Assignee:
Category:
foreman-installer script
Target version:
Difficulty:
Triaged:
Yes
Description
Currently there's a custom helper because the kafo hook is insufficient. It'd be nice to rely on pure kafo functionality.
Related issues
Associated revisions
History
#1
Updated by Ewoud Kohl van Wijngaarden 8 months ago
Updated by - Blocked by Feature #25058: Handle unknown modules in module_enabled? hook context added
#2
Updated by The Foreman Bot 8 months ago
Updated by - Assignee set to Ewoud Kohl van Wijngaarden
- Pull request https://github.com/Katello/katello-installer/pull/692 added
#3
Updated by Jonathon Turel 8 months ago
Updated by - Triaged changed from No to Yes
- Target version set to Katello 3.10.0
#4
Updated by Christine Fouant 6 months ago
Updated by - Target version changed from Katello 3.10.0 to Katello 3.11.0
#5
Updated by Jonathon Turel 4 months ago
- Target version changed from Katello 3.11.0 to Katello Backlog
#6
Updated by Ewoud Kohl van Wijngaarden 4 months ago
- Target version changed from Katello Backlog to 1.22.0
- Category changed from Installer to foreman-installer script
- Project changed from Katello to Installer
- Pull request deleted (
https://github.com/Katello/katello-installer/pull/692)
#7
Updated by The Foreman Bot about 1 month ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman-installer/pull/342 added
#8
Updated by Michael Moll about 1 month ago
Updated by - Fixed in Releases 1.22.0 added
#9
Updated by Ewoud Kohl van Wijngaarden about 1 month ago
- Status changed from Ready For Testing to Closed
Applied in changeset ff9143a4a38fd2b0bd35c8103546014effb6b96b.
Fixes #25059 - Remove local module_enabled? method
Until Kafo 3.0 its hook method didn't handle non-existing modules. Now
there's no more need for this additional check.