Project

General

Profile

Bug #25128

Template Renderer: Variables loader registry is not kept when the class is inherited

Added by Timo Goebel 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Templates
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6112
Team Backlog:
Fixed in Releases:
1.20.0
Found in Releases:

Description

It seems like the variables loader registry is not kept when the class is inherited. E.g. if I have an instance of ::Foreman::Renderer::Scope::Provisioning, @kernel is set. If I make class Bootdisk < ::Foreman::Renderer::Scope::Provisioning then @kernel is not set in an instance of Bootdisk.

Related issues

Related to Foreman - Refactor #22529: Refactor Template rendering to use a proper rendering serviceClosed

Associated revisions

Revision e50e4ffa (diff)
Added by Kamil Szubrycht 9 months ago

fixes #25128 - variables loader works with inherited classes

History

#1 Updated by Timo Goebel 9 months ago

  • Related to Refactor #22529: Refactor Template rendering to use a proper rendering service added

#2 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6112 added

#3 Updated by Timo Goebel 9 months ago

  • Fixed in Releases 1.20.0 added

#4 Updated by Anonymous 9 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF