Project

General

Profile

Actions

Bug #25228

closed

[object Object] instead of organization name on Content -> Sync status page

Added by Mirek Długosz over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Difficulty:
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

On Content -> Sync status page (/katello/sync_management) there is [object Object] instead of organization name. See attached screenshot.

Katello git commit id: 77a4d76db2d1524f152281a78ef8d17f4fdfa646
Foreman git commit id: 9ccfbde5c417ed466b21c997d01d4608cc4e8c57

On website, following message is displayed:

user: vagrant  USE eager loading detected    Katello::Product => [:provider] Add to your finder: :includes => [:provider]
user: vagrant  USE eager loading detected    Katello::Repository => [:root]  Add to your finder: :includes => [:root]
user: vagrant  USE eager loading detected    Katello::Product => [:root_repositories]  Add to your finder: :includes => [:root_repositories]
user: vagrant  USE eager loading detected    Katello::Product => [:repositories]  Add to your finder: :includes => [:repositories]

In firefox dev tools console, I see:

checkPropTypes.js:19
Warning: Failed prop type: Invalid prop `currentOrganization` of type `object` supplied to `Layout`, expected `string`.
    in Layout (created by Connect(Layout))
    in Connect(Layout)
    in Provider
checkPropTypes.js:19
Warning: Failed prop type: Invalid prop `currentOrganization` of type `object` supplied to `TaxonomySwitcher`, expected `string`.
    in TaxonomySwitcher (created by Layout)
    in Layout (created by Connect(Layout))
    in Connect(Layout)
    in Provider
checkPropTypes.js:19
Warning: Failed prop type: Invalid prop `currentTaxonomy` of type `object` supplied to `TaxonomyDropdown`, expected `string`.
    in TaxonomyDropdown (created by TaxonomySwitcher)
    in TaxonomySwitcher (created by Layout)
    in BaseVerticalNavMasthead (created by VerticalNav.Masthead)
    in VerticalNav.Masthead (created by Layout)
    in nav (created by BaseVerticalNav)
    in Unknown (created by withContext(Component))
    in withContext(Component) (created by BaseVerticalNav)
    in BaseVerticalNav (created by ControlledComponent)
    in ControlledComponent (created by VerticalNav)
    in VerticalNav (created by Layout)
    in Layout (created by Connect(Layout))
    in Connect(Layout)
    in Provider


Files

screenshot.png View screenshot.png 170 KB Mirek Długosz, 10/18/2018 11:58 AM

Related issues 1 (0 open1 closed)

Has duplicate Katello - Bug #25632: organization changed from Default org to [object Object] on sync status page in satellite WebUI.DuplicateWalden RainesActions
Actions #1

Updated by John Mitsch over 5 years ago

  • Assignee set to Walden Raines
  • Target version set to Katello 3.10.0
  • Triaged changed from No to Yes
Actions #2

Updated by Christine Fouant over 5 years ago

  • Target version changed from Katello 3.10.0 to Katello 3.11.0
Actions #3

Updated by Walden Raines over 5 years ago

  • Has duplicate Bug #25632: organization changed from Default org to [object Object] on sync status page in satellite WebUI. added
Actions #4

Updated by Walden Raines over 5 years ago

  • Assignee changed from Walden Raines to John Mitsch

Thanks for agreeing to take this John.

I have tracked this down to the fact that current_organization is returning a string in foreman - https://github.com/theforeman/foreman/pull/5898/files#diff-d07b3cdd6c00768e06bfed349d3c808fR28

And an object in this old katello page - https://github.com/Katello/katello/blob/master/app/controllers/katello/application_controller.rb#L52-L73

As far as I can tell the sync management page is the only page that uses Katello::ApplicationController, the rest inherit from ::ApplicationController.

Actions #5

Updated by John Mitsch over 5 years ago

  • Bugzilla link set to 1651129
Actions #6

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7874 added
Actions #7

Updated by John Mitsch over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF