Bug #25228
closed[object Object] instead of organization name on Content -> Sync status page
Description
On Content -> Sync status page (/katello/sync_management) there is [object Object]
instead of organization name. See attached screenshot.
Katello git commit id: 77a4d76db2d1524f152281a78ef8d17f4fdfa646
Foreman git commit id: 9ccfbde5c417ed466b21c997d01d4608cc4e8c57
On website, following message is displayed:
user: vagrant USE eager loading detected Katello::Product => [:provider] Add to your finder: :includes => [:provider] user: vagrant USE eager loading detected Katello::Repository => [:root] Add to your finder: :includes => [:root] user: vagrant USE eager loading detected Katello::Product => [:root_repositories] Add to your finder: :includes => [:root_repositories] user: vagrant USE eager loading detected Katello::Product => [:repositories] Add to your finder: :includes => [:repositories]
In firefox dev tools console, I see:
checkPropTypes.js:19 Warning: Failed prop type: Invalid prop `currentOrganization` of type `object` supplied to `Layout`, expected `string`. in Layout (created by Connect(Layout)) in Connect(Layout) in Provider checkPropTypes.js:19 Warning: Failed prop type: Invalid prop `currentOrganization` of type `object` supplied to `TaxonomySwitcher`, expected `string`. in TaxonomySwitcher (created by Layout) in Layout (created by Connect(Layout)) in Connect(Layout) in Provider checkPropTypes.js:19 Warning: Failed prop type: Invalid prop `currentTaxonomy` of type `object` supplied to `TaxonomyDropdown`, expected `string`. in TaxonomyDropdown (created by TaxonomySwitcher) in TaxonomySwitcher (created by Layout) in BaseVerticalNavMasthead (created by VerticalNav.Masthead) in VerticalNav.Masthead (created by Layout) in nav (created by BaseVerticalNav) in Unknown (created by withContext(Component)) in withContext(Component) (created by BaseVerticalNav) in BaseVerticalNav (created by ControlledComponent) in ControlledComponent (created by VerticalNav) in VerticalNav (created by Layout) in Layout (created by Connect(Layout)) in Connect(Layout) in Provider
Files
Updated by John Mitsch over 6 years ago
- Assignee set to Walden Raines
- Target version set to Katello 3.10.0
- Triaged changed from No to Yes
Updated by Christine Fouant about 6 years ago
- Target version changed from Katello 3.10.0 to Katello 3.11.0
Updated by Walden Raines about 6 years ago
- Has duplicate Bug #25632: organization changed from Default org to [object Object] on sync status page in satellite WebUI. added
Updated by Walden Raines about 6 years ago
- Assignee changed from Walden Raines to John Mitsch
Thanks for agreeing to take this John.
I have tracked this down to the fact that current_organization is returning a string in foreman - https://github.com/theforeman/foreman/pull/5898/files#diff-d07b3cdd6c00768e06bfed349d3c808fR28
And an object in this old katello page - https://github.com/Katello/katello/blob/master/app/controllers/katello/application_controller.rb#L52-L73
As far as I can tell the sync management page is the only page that uses Katello::ApplicationController, the rest inherit from ::ApplicationController.
Updated by The Foreman Bot about 6 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello/pull/7874 added
Updated by John Mitsch about 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|013fd5f3ed9ca9ef2a0820265fc3f446d4e0a2d4.