Project

General

Profile

Bug #25230

compute resource test connection is html incorrectly escaped

Added by Ohad Levy 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

see attachment

steps to reproduce

1. create / edit a compute resource
2. click on test connection
3. see incorrect toast message.

cr-test.png View cr-test.png 5.9 KB Ohad Levy, 10/18/2018 12:42 PM
Cr test

Related issues

Related to Foreman - Bug #24807: CVE-2018-16861 - toast notification sends strings through as HTMLClosed
Has duplicate Foreman - Bug #25456: Test connection on compute resource shows notification with html tagsDuplicate

Associated revisions

Revision b96e66b4 (diff)
Added by Tomer Brisker 2 months ago

Fixes #25230 - Remove useless html from toast notifications

History

#1 Updated by Ohad Levy 2 months ago

  • Related to Bug #24807: CVE-2018-16861 - toast notification sends strings through as HTML added

#2 Updated by The Foreman Bot 2 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6154 added

#3 Updated by Tomer Brisker 2 months ago

  • Triaged changed from No to Yes
  • Category changed from Compute resources to Web Interface

The same issue is also present for email and auth source test connection buttons.

#4 Updated by Ohad Levy 2 months ago

  • Target version set to 1.20.0

I would suggest cherrypicking to 1.20?

#5 Updated by Tomer Brisker 2 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 1.20.0 added

cherry-picked.

#7 Updated by Tomer Brisker about 1 month ago

  • Has duplicate Bug #25456: Test connection on compute resource shows notification with html tags added

Also available in: Atom PDF