Project

General

Profile

Bug #25291

foreman-maintain doesn't quit the actual run when q is pressed

Added by Kavita Gaikwad over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1640974

Description of problem:
foreman-maintain doesn't quit the actual run when q is pressed

Version-Release number of selected component (if applicable):

rubygem-foreman_maintain-0.2.11-1.el7sat.noarch

How reproducible:
100%

Steps to Reproduce:
1. Run the Satellite 6.4 upgrade check as shown below
Running Checks before upgrading to Satellite 6.4 ================================================================================
Check for verifying syntax for ISP DHCP configurations: [SKIPPED]
DHCP feature is not enabled
--------------------------------------------------------------------------------
Check whether all services are running: [OK]
--------------------------------------------------------------------------------
Check whether all services are running using hammer ping: [OK]
--------------------------------------------------------------------------------
Check for paused tasks: [OK]
--------------------------------------------------------------------------------
Check to validate candlepin database: [OK]
--------------------------------------------------------------------------------
Check if EPEL repository enabled on system:
/ Checking for presence of EPEL repository [OK]
--------------------------------------------------------------------------------
Check for running tasks: [OK]
--------------------------------------------------------------------------------
Check for old tasks in paused/stopped state: [FAIL]
Found 11 paused or stopped task(s) older than 30 days
--------------------------------------------------------------------------------
Continue with step [Delete old tasks]?, [y(yes), n(no), q(quit)] q -----> q is pressed
Check for pending tasks which are safe to delete: [OK]
--------------------------------------------------------------------------------
Check for tasks in planning state: [OK]
--------------------------------------------------------------------------------
Check for recommended disk speed of pulp, mongodb, pgsql dir.:
\ Finished

Disk speed : 21 MB/sec [FAIL]
Slow disk detected /var/lib/pulp mounted on /dev/mapper/myvg-rootvol.
Actual disk speed: 21 MB/sec
Expected disk speed: 60 MB/sec.
--------------------------------------------------------------------------------
Check whether reports have correct associations: [OK]
--------------------------------------------------------------------------------
Verify puppet and provide upgrade guide for it:
/ current puppet version: [OK]
--------------------------------------------------------------------------------
Validate availability of repositories:
/ Validating availability of repositories for 6.4 [OK]
--------------------------------------------------------------------------------
Scenario [Checks before upgrading to Satellite 6.4] failed.

The following steps ended up in failing state:

[check-old-foreman-tasks]
[disk-performance]

Actual results:
Even after pressing q (quit) option foreman-maintain utility ran further

Expected results:
q (quit) should quit as specified

Additional info:

Associated revisions

Revision 413f582a (diff)
Added by Kavita Gaikwad over 1 year ago

Fixes #25291 - don't add quit action on fail_slow run_strategy

Revision 9e6a344c (diff)
Added by Kavita Gaikwad over 1 year ago

Refs #25291 - remove dead code

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/358 added

#2 Updated by Kavita Gaikwad over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF