Project

General

Profile

Bug #25304

Building the installer no longer uncomments the kafo_modules_dir

Added by Ewoud Kohl van Wijngaarden about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
foreman-installer script
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:

Description

In 9929fe2ed9009fdec146a6ee75f2f2d7f084f6f7 the building process was changed. A regression was introduced that no longer uncommented the kafo_modules_dir.

Source (config/foreman.yaml):

# :kafo_modules_dir: /usr/lib/ruby/vendor_ruby/kafo/modules

With the command:

KAFO_MODULES_DIR=/path/to/kafo/modules bundle exec rake

Before the regression it produced:

:kafo_modules_dir: /path/to/kafo/modules

After the regression it didn't uncomment the setting:

# :kafo_modules_dir: /path/to/kafo/modules

Associated revisions

Revision 3ff078d1 (diff)
Added by Ewoud Kohl van Wijngaarden about 2 months ago

Fixes #25304 - Correct handle kafo_modules_dir

In 9929fe2ed9009fdec146a6ee75f2f2d7f084f6f7 the building process was
changed. A regression was introduced that no longer uncommented the
kafo_modules_dir.

Source (config/foreman.yaml):

  1. :kafo_modules_dir: /usr/lib/ruby/vendor_ruby/kafo/modules

With the command:

KAFO_MODULES_DIR=/path/to/kafo/modules bundle exec rake

Before the regression it produced:

:kafo_modules_dir: /path/to/kafo/modules

After the regression it didn't uncomment the setting:

  1. :kafo_modules_dir: /path/to/kafo/modules

This patch restores the old behavior.

History

#1 Updated by The Foreman Bot about 2 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-installer/pull/300 added

#2 Updated by Ewoud Kohl van Wijngaarden about 2 months ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 1.20.0 added

Also available in: Atom PDF