Project

General

Custom queries

Profile

Actions
Copy link

Bug #25304

closed

Building the installer no longer uncomments the kafo_modules_dir

Added by Ewoud Kohl van Wijngaarden over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
foreman-installer script
Target version:
Foreman - 1.20.0
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman-installer/pull/300
Fixed in Releases:
Foreman - 1.20.0
Found in Releases:
Foreman - 1.20.0, Foreman - 1.21.0
Red Hat JIRA:

Description

In 9929fe2ed9009fdec146a6ee75f2f2d7f084f6f7 the building process was changed. A regression was introduced that no longer uncommented the kafo_modules_dir.

Source (config/foreman.yaml):

# :kafo_modules_dir: /usr/lib/ruby/vendor_ruby/kafo/modules

With the command:

KAFO_MODULES_DIR=/path/to/kafo/modules bundle exec rake

Before the regression it produced:

:kafo_modules_dir: /path/to/kafo/modules

After the regression it didn't uncomment the setting:

# :kafo_modules_dir: /path/to/kafo/modules

Added by Ewoud Kohl van Wijngaarden over 6 years ago

Revision 3ff078d1 (diff)

Fixes #25304 - Correct handle kafo_modules_dir

In 9929fe2ed9009fdec146a6ee75f2f2d7f084f6f7 the building process was
changed. A regression was introduced that no longer uncommented the
kafo_modules_dir.

Source (config/foreman.yaml):

  1. :kafo_modules_dir: /usr/lib/ruby/vendor_ruby/kafo/modules

With the command:

KAFO_MODULES_DIR=/path/to/kafo/modules bundle exec rake

Before the regression it produced:

:kafo_modules_dir: /path/to/kafo/modules

After the regression it didn't uncomment the setting:

  1. :kafo_modules_dir: /path/to/kafo/modules

This patch restores the old behavior.

Actions
Copy link

Also available in: Atom PDF