Project

General

Profile

Actions

Bug #25305

closed

Validation failed: Puppet class can't be blank when importing puppet classes

Added by Timo Goebel over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Puppet integration
Target version:
-
Difficulty:
easy
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

Puppet Class import fails with "ActiveRecord::RecordInvalid: Validation failed: Puppet class can't be blank" when user does not have create_puppetclasses permission.

We should add a proper error message when https://github.com/theforeman/foreman/blob/f22a6c642a161bee0131e826cf9e7726fb901b08/app/services/puppet_class_importer.rb#L259 fails to create the puppetclass.

Actions #1

Updated by Lukas Zapletal about 6 years ago

  • Triaged changed from No to Yes
Actions #2

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Timo Goebel
  • Pull request https://github.com/theforeman/foreman/pull/6199 added
Actions #3

Updated by Ondřej Pražák about 6 years ago

  • Status changed from Ready For Testing to Closed
  • Fixed in Releases 1.21.0 added
Actions

Also available in: Atom PDF