Bug #25331: Fact imports erranously cause audits to be created - Foreman

Bug #25331

Fact imports erranously cause audits to be created

Added by Timo Goebel over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

High

Assignee:

Lukas Zapletal

Category:

Audit Log

Target version:

Difficulty:

Triaged:

Yes

Bugzilla link:

1660489

Pull request:

https://github.com/theforeman/foreman/pull/6178, https://github.com/theforeman/foreman/pull/6198, https://github.com/theforeman/foreman/pull/6182, https://github.com/theforeman/foreman/pull/6179

Fixed in Releases:

1.19.1, 1.20.0

Found in Releases:

1.19.0

Red Hat JIRA:

Description

For very fact import an audit record is written although nothing changes.

#&lt;Audited::Audit id: 8238963, auditable_id: 30056, auditable_type: "Nic::Managed", user_id: 4, user_type: nil, username: "API Admin", action: "update", audited_changes: {"attrs"=&gt;[{"mtu"=>"1500", "netmask"=>"255.255.224.0", "netmask6"=>"ffff:ffff:ffff:ffff::", "network"=>"172.22.0.0", "network6"=>"fe80::"}, {"mtu"=>1500, "netmask"=>"255.255.224.0", "netmask6"=>"ffff:ffff:ffff:ffff::", "network"=>"172.22.0.0", "network6"=>"fe80::"}]}, version: 7, comment: nil, associated_id: 23973, associated_type: "Host::Base", request_uuid: "7263349c-f216-415a-8721-f7464856031e", created_at: "2018-10-29 10:08:25", remote_address: "1.2.3.4", auditable_name: "xxxxx...", associated_name: "xxxx...">

47642985-6e661400-db6a-11e8-9cf1-2c0ce08f13e9.png

View 47642985-6e661400-db6a-11e8-9cf1-2c0ce08f13e9.png

105 KB

Timo Goebel, 10/29/2018 10:06 AM

Related issues

Associated revisions

Revision 6e9be602 (diff)
Added by Timo Goebel over 4 years ago

fixes #25331 - do not audit fact import

History

#1 Updated by Lukas Zapletal over 4 years ago

Priority changed from Normal to High
Status changed from New to Need more information

Timo, thanks. Is this per fact upload or per single change of a fact? The latter looks like important issue for performance.

#2 Updated by Timo Goebel over 4 years ago

Status changed from Need more information to New

This is per fact upload as far as I traced it.

#3 Updated by Timo Goebel over 4 years ago

I have slowed down the effect by sorting the hash in /usr/share/foreman/app/models/host/base.rb

-iface.attrs = attributes
+iface.attrs = attributes.sort.to_h

The diff in the example above is that mtu seems to toggle between integer and string.

Tomer proposed that we don't write any audits at all during fact import. While that might be a good approach we should also not update the interface unless something really changed.