Project

General

Profile

Actions

Bug #25382

closed

Autocomplete test fails when trying to update Jest 23.6

Added by Ron Lavi about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

The global/window object seem to change through the update,
in my opinion, simulate shouldn't be used on the window object as it isn't
working as the DOM window, calling the function which is triggered by window's key press
is really what we want to test, and almost sure not to fail in future Jest/Enzyme upgrades.

Actions #1

Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6201 added
Actions #2

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6191 added
Actions #3

Updated by Tomer Brisker about 6 years ago

  • Fixed in Releases 1.21.0 added
Actions #4

Updated by Tomer Brisker about 6 years ago

  • Pull request deleted (https://github.com/theforeman/foreman/pull/6201)
Actions #5

Updated by Ron Lavi about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF