Project

General

Profile

Actions

Bug #25407

closed

Katello::Resources::Candlepin::Consumer.get not always returns HashWithIndifferentAccess

Added by Evgeni Golov over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
-
Target version:
Fixed in Releases:
Found in Releases:

Description

ActiveSupport::HashWithIndifferentAccess allows to access Hashes in Ruby by either 'string' or :symbol Katello::Resources::Candlepin::Consumer.get will return a HashWithIndifferentAccess when called with a String param, but will only return a regular Hash when called with a Hash full of params.

As we use symbol-access in many places (like in Katello::Actions::Katello::Host::HypervisorsUpdate), but the data comes from JSON.parse originally, we should always map to HashWithIndifferentAccess

Actions #1

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7817 added
Actions #2

Updated by Evgeni Golov over 5 years ago

  • Triaged changed from Yes to No
Actions #3

Updated by Justin Sherrill over 5 years ago

  • Target version set to Katello 3.10.0
  • Triaged changed from No to Yes
Actions #4

Updated by Evgeni Golov over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/Katello/katello/pull/7872 added
Actions #6

Updated by John Mitsch over 5 years ago

  • Bugzilla link set to 1653386
Actions

Also available in: Atom PDF