Project

General

Profile

Bug #25483

Custom boolean facts with false value are not imported

Added by Marek Hulán 10 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Facts
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1650127

Description of problem:
Custome Boolean Puppet facts with value False are not on the WebUI, Hammer output or with REST API. Only facts with value True are shown/stored.

Version-Release number of selected component (if applicable):
Satellite 6.4
Puppet 5

How reproducible:
Always

Steps to Reproduce:
In /opt/puppetlabs/puppet/cache/lib/facter

  1. cat temp.rb
    require 'facter'

Facter.add("always_true") do
confine :kernel => "Linux"
setcode do
true
end
end

Facter.add("always_false") do
confine :kernel => "Linux"
setcode do
false
end
end

Actual results:
- False value is not displayed
  1. hammer fact list --search "name=always_true"
    ----------------------|-------------|------
    HOST | FACT | VALUE
    ----------------------|-------------|------
    lvmpig03 | always_true | true
    ----------------------|-------------|------
Expected results:
- False value should be displayed
  1. hammer fact list --search "name=always_false"
    ----------------------|-------------|------
    HOST | FACT | VALUE
    ----------------------|-------------|------
    lvmpig03 | always_false | false
    lvmpig03 | always_true | true
    ----------------------|-------------|------

Related issues

Has duplicate Foreman - Bug #25949: Boolean false facts do not show up in the web UIDuplicate
Has duplicate Foreman - Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed CorrectlyDuplicate

Associated revisions

Revision c5894189 (diff)
Added by Marek Hulán 9 months ago

Fixes #25483 - keep false facts

History

#1 Updated by Marek Hulán 10 months ago

  • Assignee set to Marek Hulán
  • Status changed from New to Assigned
  • Subject changed from Custom boolean facts with false value are not managed by Satellite. to Custom boolean facts with false value are not managed by Satellite.

in fact we ignore all false facts, not just custom

#2 Updated by Marek Hulán 10 months ago

  • Category set to Facts
  • Project changed from Ansible to Foreman

#3 Updated by The Foreman Bot 10 months ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6253 added

#4 Updated by Michael Moll 9 months ago

  • Fixed in Releases 1.21.0 added

#5 Updated by Marek Hulán 9 months ago

  • Status changed from Ready For Testing to Closed

#6 Updated by Ewoud Kohl van Wijngaarden 8 months ago

  • Subject changed from Custom boolean facts with false value are not managed by Satellite. to Custom boolean facts with false value are not imported

#7 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Related to Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed Correctly added

#8 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Has duplicate Bug #25949: Boolean false facts do not show up in the web UI added

#9 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Related to deleted (Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed Correctly)

#10 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Related to Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed Correctly added

#11 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Related to deleted (Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed Correctly)

#12 Updated by Ewoud Kohl van Wijngaarden 6 months ago

  • Has duplicate Bug #23960: Foreman - "fips_enabled" Puppet Fact is not Parsed Correctly added

Also available in: Atom PDF