Project

General

Profile

Bug #25523

make i18n js code more resilient to errors

Added by Tomer Brisker 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
JavaScript stack
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

in case window.locale doesn't contain the needed locale, JED initialization fails with an error and all js code fails to load.
Offending line: https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/common/I18n.js#L15


Related issues

Related to Foreman - Bug #25517: Debian packages don't build localized js filesClosed

Associated revisions

Revision c8db244a (diff)
Added by Tomer Brisker 4 months ago

Fixes #25523 - Fallback to english if js locale is missing

History

#1 Updated by The Foreman Bot 4 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6268 added

#2 Updated by Tomer Brisker 4 months ago

  • Related to Bug #25517: Debian packages don't build localized js files added

#3 Updated by Tomer Brisker 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Tomer Brisker 4 months ago

  • Fixed in Releases 1.21.0 added

#5 Updated by Tomer Brisker 4 months ago

  • Fixed in Releases 1.20.1 added

Also available in: Atom PDF