Project

General

Profile

Actions
Copy link

Bug #25523

closed

make i18n js code more resilient to errors

Added by Tomer Brisker over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
JavaScript stack
Target version:
1.20.1
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6268
Fixed in Releases:
1.20.1, 1.21.0
Found in Releases:
Red Hat JIRA:

Description

in case window.locale doesn't contain the needed locale, JED initialization fails with an error and all js code fails to load.
Offending line: https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/common/I18n.js#L15

Related issues 1 (0 open — 1 closed)

Related to Foreman - Bug #25517: Debian packages don't build localized js filesClosedActions
Actions
Copy link
 #1

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/6268 added
Actions
Copy link
 #2

Updated by Tomer Brisker over 5 years ago

  • Related to Bug #25517: Debian packages don't build localized js files added
Actions
Copy link
 #3

Updated by Tomer Brisker over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #4

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.21.0 added
Actions
Copy link
 #5

Updated by Tomer Brisker over 5 years ago

  • Fixed in Releases 1.20.1 added
Actions
Copy link

Also available in: Atom PDF