Project

General

Profile

Actions

Bug #25593

closed

Dynflow executor termination may hang if there is an action which keeps the executor occupied

Added by Ivan Necas over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Dynflow
Target version:
-
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1654975

Description of problem:
If there is an action which is running on an executor for a long time and it does not suspend itself and the memory watcher decides to recycle the executor, the termination may hang indefinitely.

Version-Release number of selected component (if applicable):

How reproducible:
always

Steps to Reproduce:
1. Pick any action, add infinite sleep to the beginning of its run method
2. Trigger the action
3. Wait for the memory watcher to try restarting the executor

Actual results:
The termination hangs, the dynflow executor process stays there, not releasing its resources.

Expected results:
The dynflow executor process gets terminated

Additional info:


Related issues 1 (0 open1 closed)

Blocks foreman-tasks - Bug #25021: The termination procedure after memory threshold exceeded can get stuck, waiting infinitely for some events to occurClosedActions
Actions #1

Updated by Ivan Necas over 5 years ago

  • Subject changed from Dynflow executor termination may hang if there is an action which keeps the executor occupied to Dynflow executor termination may hang if there is an action which keeps the executor occupied
  • Category set to Dynflow
  • Status changed from New to Closed
  • Pull request https://github.com/Dynflow/dynflow/pull/301 added
Actions #2

Updated by Ivan Necas over 5 years ago

  • Blocks Bug #25021: The termination procedure after memory threshold exceeded can get stuck, waiting infinitely for some events to occur added
Actions #3

Updated by Adam Ruzicka over 5 years ago

  • Fixed in Releases dynflow-1.1.4 added
Actions #4

Updated by Ivan Necas over 5 years ago

  • Status changed from Closed to Assigned
  • Pull request https://github.com/Dynflow/dynflow/pull/312 added
  • Fixed in Releases deleted (dynflow-1.1.4)

Added additional PR to enhance the patch checking for state of the concurrent ruby executor

Actions #5

Updated by Ivan Necas over 5 years ago

  • Status changed from Assigned to Closed
Actions #6

Updated by Ivan Necas over 5 years ago

  • Fixed in Releases dynflow-1.1.6 (Foreman 1.20) added
Actions

Also available in: Atom PDF