Actions
Refactor #25605
closeddrop hypervisor_guest_uuids from SubscriptionFacet
Pull request:
Fixed in Releases:
Found in Releases:
Description
currently, SubscriptionFacet.hypervisor_guest_uuids
is never set, as the assignment is conditional on an non-existing key:
def update_from_consumer_attributes(consumer_params) import_database_attributes(consumer_params) self.hypervisor_guest_uuids = consumer_params['guestIds'] unless consumer_params['hypervisor_guest_uuids'].blank? self.facts = consumer_params['facts'] unless consumer_params['facts'].blank? end
And if you change that to the correct key:
self.hypervisor_guest_uuids = consumer_params['guestIds'] unless consumer_params['guestIds'].blank?
you end up with an error:
NoMethodError: undefined method `hypervisor_guest_uuids=' for #<Katello::Host::SubscriptionFacet:0x000055d632ba3b60>
As such, I think hypervisor_guest_uuids
is unused and can be removed.
Actions