Project

General

Profile

Actions
Copy link

Refactor #25665

closed

Use bash comparisons in katello-certs-check

Added by Ewoud Kohl van Wijngaarden over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Installer
Target version:
Katello 3.11.0
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello-installer/pull/729
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The use of == is a bash-only feature. Since we're using this already, we might as well go all the way and use the safer checks.

Using $() instead of `` is also a better practice because it allows nesting and slightly easier to read.

Actions
Copy link
 #1

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/Katello/katello-installer/pull/729 added
Actions
Copy link
 #2

Updated by Ewoud Kohl van Wijngaarden over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #3

Updated by Jonathon Turel over 5 years ago

  • Target version set to Katello 3.11.0
  • Triaged changed from No to Yes
Actions
Copy link

Also available in: Atom PDF