Project

General

Profile

Refactor #25665

Use bash comparisons in katello-certs-check

Added by Ewoud Kohl van Wijngaarden 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Category:
Installer
Target version:
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The use of == is a bash-only feature. Since we're using this already, we might as well go all the way and use the safer checks.

Using $() instead of `` is also a better practice because it allows nesting and slightly easier to read.

Associated revisions

Revision ebdebefb (diff)
Added by Ewoud Kohl van Wijngaarden 9 months ago

Fixes #25665 - Use the bash comparisons can function calls

The use of == is a bash-only feature. Since we're using this already, we
might as well go all the way and use the safer checks.

Using $() instead of `` is also a better practice because it allows
nesting and slightly easier to read.

History

#1 Updated by The Foreman Bot 9 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello-installer/pull/729 added

#2 Updated by Ewoud Kohl van Wijngaarden 9 months ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Jonathon Turel 8 months ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.11.0

Also available in: Atom PDF