Project

General

Profile

Actions

Bug #2571

closed

unexpected return (LocalJumpError) running tests

Added by Dominic Cleal almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

All of a sudden, develop tests are failing with this one error:

unexpected return (LocalJumpError)
/var/lib/workspace/workspace/test_develop/database/postgresql/puppet/3.0/ruby/1.8.7/test/functional/users_controller_test.rb:139
/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop-1/gems/minitest-spec-rails-4.7.3/lib/minitest-spec-rails/dsl.rb:22:in `instance_eval'
/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop-1/gems/minitest-spec-rails-4.7.3/lib/minitest-spec-rails/dsl.rb:22:in `test_0012_anonymous'

http://ci.theforeman.org/job/test_develop/database=postgresql,puppet=3.0,ruby=1.8.7/lastCompletedBuild/testReport/%28root%29/UsersControllerTest/test_0012_anonymous/

The first return line isn't valid, since tests all assume logins are enabled. I can't see what the second return line is trying to achieve, seems that the test will never run. Perhaps remove it and check the test still passes.

Actions #1

Updated by Marek Hulán almost 11 years ago

  • Status changed from New to Assigned
  • Assignee set to Marek Hulán
Actions #2

Updated by Marek Hulán almost 11 years ago

  • Status changed from Assigned to Ready For Testing

This test was added in #390. Test could never work as expected. Later the admin autocreation was moved to User model (see commit) but the test remained here. I fixed and moved the test to user model unit test where I think it belongs. PR with fix is here

Actions #3

Updated by Marek Hulán almost 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF