Project

General

Profile

Bug #2571

unexpected return (LocalJumpError) running tests

Added by Dominic Cleal about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Immediate
Assignee:
Category:
Tests
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

All of a sudden, develop tests are failing with this one error:

unexpected return (LocalJumpError)
/var/lib/workspace/workspace/test_develop/database/postgresql/puppet/3.0/ruby/1.8.7/test/functional/users_controller_test.rb:139
/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop-1/gems/minitest-spec-rails-4.7.3/lib/minitest-spec-rails/dsl.rb:22:in `instance_eval'
/usr/local/rvm/gems/ruby-1.8.7-p371@test_develop-1/gems/minitest-spec-rails-4.7.3/lib/minitest-spec-rails/dsl.rb:22:in `test_0012_anonymous'

http://ci.theforeman.org/job/test_develop/database=postgresql,puppet=3.0,ruby=1.8.7/lastCompletedBuild/testReport/%28root%29/UsersControllerTest/test_0012_anonymous/

The first return line isn't valid, since tests all assume logins are enabled. I can't see what the second return line is trying to achieve, seems that the test will never run. Perhaps remove it and check the test still passes.

Associated revisions

Revision 4df2e17b (diff)
Added by Marek Hulán about 6 years ago

Fixes #2571 - Deleted admin is recreated

Revision 0580bf98 (diff)
Added by Marek Hulán about 6 years ago

Fixes #2571 - Deleted admin is recreated
(cherry picked from commit 4df2e17b75c65fa657ef9499ccf9c71547f11dcf)

History

#1 Updated by Marek Hulán about 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Marek Hulán

#2 Updated by Marek Hulán about 6 years ago

  • Status changed from Assigned to Ready For Testing

This test was added in #390. Test could never work as expected. Later the admin autocreation was moved to User model (see commit) but the test remained here. I fixed and moved the test to user model unit test where I think it belongs. PR with fix is here

#3 Updated by Marek Hulán about 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF