Project

General

Profile

Actions

Bug #25758

closed

Fix tests for taxonomies

Added by Rahul Bajaj over 6 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Many tests check whether there is a org/loc present if not then they return []
which is not appropriate as after @tbrisker's changes, taxonomies can not be
blank.

```

trait :with_subnet do
subnet do
FactoryBot.build(:subnet_ipv4,
:organizations => host ? [host.organization] : [],
:locations => host ? [host.location] : [])
end
end

```

The `host_related.rb` file has many such test cases.

Actions #1

Updated by Rahul Bajaj over 6 years ago

  • Description updated (diff)
Actions #2

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6422 added
Actions #3

Updated by Rahul Bajaj over 6 years ago

  • Status changed from Ready For Testing to Closed
Actions #4

Updated by Tomer Brisker over 6 years ago

  • Status changed from Closed to Rejected
Actions

Also available in: Atom PDF