Project

General

Profile

Actions
Copy link

Bug #25824

closed

Test failure with latest Sinatra: can't dup NilClass (TypeError)

Added by Lukas Zapletal almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
BMC
Target version:
-
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/628, https://github.com/theforeman/smart-proxy/pull/629, https://github.com/theforeman/smart-proxy/pull/630, https://github.com/theforeman/smart-proxy/pull/631
Fixed in Releases:
Foreman - 1.20.2, Foreman - 1.21.0
Found in Releases:
Red Hat JIRA:

Description

Recent change in Sinatra codebase fails one of our tests:

https://github.com/sinatra/sinatra/pull/1479#issuecomment-453034886

can't dup NilClass (TypeError)
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1092:in `dup'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1092:in `block in dispatch!'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1092:in `each'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1092:in `dispatch!'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:924:in `block in call!'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1076:in `block in invoke'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1076:in `catch'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1076:in `invoke'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:924:in `call!'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:913:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/xss_header.rb:18:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/path_traversal.rb:16:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/json_csrf.rb:26:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/base.rb:50:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/base.rb:50:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-protection-2.0.5/lib/rack/protection/frame_options.rb:31:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-2.0.6/lib/rack/null_logger.rb:9:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-2.0.6/lib/rack/head.rb:12:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:194:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/sinatra-2.0.5/lib/sinatra/base.rb:1957:in `call'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-test-1.1.0/lib/rack/mock_session.rb:29:in `request'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-test-1.1.0/lib/rack/test.rb:266:in `process_request'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-test-1.1.0/lib/rack/test.rb:129:in `custom_request'
/usr/local/rvm/gems/ruby-2.3.5@test_proxy_develop_pr_core-1/gems/rack-test-1.1.0/lib/rack/test.rb:58:in `get'
/usr/local/rvm/rubies/ruby-2.3.5/lib/ruby/2.3.0/forwardable.rb:204:in `get'
/var/lib/workspace/workspace/test_proxy_develop_pr_core/puppet/4.10.0/ruby/2.3/test/bmc/bmc_api_test.rb:179:in `test_api_recovers_from_nil_provider'
Actions
Copy link
 #1

Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/628 added
Actions
Copy link
 #2

Updated by The Foreman Bot almost 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/629 added
Actions
Copy link
 #3

Updated by The Foreman Bot almost 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/630 added
Actions
Copy link
 #4

Updated by The Foreman Bot almost 6 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/631 added
Actions
Copy link
 #5

Updated by Anonymous almost 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #6

Updated by Anonymous almost 6 years ago

  • Fixed in Releases 1.20.2, 1.21.0 added
Actions
Copy link
 #7

Updated by Tomer Brisker almost 6 years ago

  • Fixed in Releases deleted ()

With 1.21 due soon, there will likely not be a 1.19.2 release. Removing.

Actions
Copy link

Also available in: Atom PDF