Project

General

Profile

Refactor #25839

Avoid storing puppetserver version related parameters in the answer file

Added by Ewoud Kohl van Wijngaarden 4 months ago. Updated 4 months ago.


Description

Currently we store some parameters in the answers file that relate to the puppetserver version. This is because we determine them in params.pp which means init.pp has them. The result is that when a user upgrades, their answers need to be reset. Katello has a hook to always do this, Foreman has nothing.

By defaulting to undef and moving the the determination into server.pp we can avoid this whole problem.

Associated revisions

Revision 899bb08f (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Fixes #25839 - Determine puppetserver version in server.pp

Currently we store some parameters in the installers answers file that
relate to the puppetserver version. This is because we determine them in
params.pp which means init.pp has them. The result is that when a user
upgrades, their answers need to be reset. Katello has a hook to always
do this, Foreman has nothing.

By defaulting to undef and moving the the determination into server.pp
we can avoid this whole problem.

Revision e2318692 (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Refs #25839 - Avoid storing puppetserver related versions

Revision 86bbff5b (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Refs #25839 - Use the correct variable

Revision 11e0e174 (diff)
Added by Ewoud Kohl van Wijngaarden 4 months ago

Refs #25839 - Use the correct variable

History

#1 Updated by The Foreman Bot 4 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-puppet/pull/668 added

#2 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/311 added

#3 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Status changed from Ready For Testing to Closed

#4 Updated by Ewoud Kohl van Wijngaarden 4 months ago

  • Fixed in Releases 1.21.0 added

#5 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/313 added

#6 Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/theforeman/foreman-installer/pull/316 added

Also available in: Atom PDF