Refactor #25839
Avoid storing puppetserver version related parameters in the answer file
Status:
Closed
Priority:
Normal
Assignee:
Category:
Foreman modules
Target version:
Description
Currently we store some parameters in the answers file that relate to the puppetserver version. This is because we determine them in params.pp which means init.pp has them. The result is that when a user upgrades, their answers need to be reset. Katello has a hook to always do this, Foreman has nothing.
By defaulting to undef and moving the the determination into server.pp we can avoid this whole problem.
Associated revisions
Refs #25839 - Avoid storing puppetserver related versions
Refs #25839 - Use the correct variable
Refs #25839 - Use the correct variable
History
#1
Updated by The Foreman Bot almost 2 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/puppet-puppet/pull/668 added
#2
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/theforeman/foreman-installer/pull/311 added
#3
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
Updated by - Status changed from Ready For Testing to Closed
Applied in changeset puppet-puppet|899bb08fd4440dbcee735ed613d2bb597b7e3b42.
#4
Updated by Ewoud Kohl van Wijngaarden almost 2 years ago
- Fixed in Releases 1.21.0 added
#5
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/theforeman/foreman-installer/pull/313 added
#6
Updated by The Foreman Bot almost 2 years ago
- Pull request https://github.com/theforeman/foreman-installer/pull/316 added
Fixes #25839 - Determine puppetserver version in server.pp
Currently we store some parameters in the installers answers file that
relate to the puppetserver version. This is because we determine them in
params.pp which means init.pp has them. The result is that when a user
upgrades, their answers need to be reset. Katello has a hook to always
do this, Foreman has nothing.
By defaulting to undef and moving the the determination into server.pp
we can avoid this whole problem.