Project

General

Profile

Bug #25882

webpack plugin compilation ignores all but main index.js entry

Added by Justin Sherrill 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
JavaScript stack
Target version:

Description

script/plugin_webpack_directories.rb#L28 supports plugins to have multiple 'bundles/entries' of assets, however during production compilation, these extra bundles are ignored:

https://github.com/theforeman/foreman/blob/develop/config/webpack.config.js#L73


Related issues

Blocks Katello - Bug #25883: adapt to new webpack bundle entry formatClosed

Associated revisions

Revision 202c65d0 (diff)
Added by Justin Sherrill 10 months ago

Fixes #25882 - compile extra bundles during plugin compile

Revision 92a0079a (diff)
Added by Justin Sherrill 10 months ago

Refs #25882 - use working iterator for webpack entries

Revision 22c7c988 (diff)
Added by Ewoud Kohl van Wijngaarden 10 months ago

Refs #25882 - Load additional plugin chunks

When loading the manifest.json from a plugin we need to include plugin
and plugin:*.

bc486dd62734be908cd3f95da1352cc1944eb34b attempted to make it possible
to create additional bundles. 202c65d0efc0345b883ba6d1e70aedc90b3d5294
then configured webpack to actually compile the bundle during build.
This completes the chain by loading it in the actual manifest so you can
use it in a production build where the development server isn't present.

History

#1 Updated by The Foreman Bot 10 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6421 added

#2 Updated by Justin Sherrill 10 months ago

  • Related to Bug #25883: adapt to new webpack bundle entry format added

#3 Updated by Justin Sherrill 10 months ago

  • Related to deleted (Bug #25883: adapt to new webpack bundle entry format)

#4 Updated by Justin Sherrill 10 months ago

  • Blocks Bug #25883: adapt to new webpack bundle entry format added

#5 Updated by Justin Sherrill 10 months ago

  • Target version set to 1.21.0

#6 Updated by Tomer Brisker 10 months ago

  • Fixed in Releases 1.21.0 added

#7 Updated by Justin Sherrill 10 months ago

  • Status changed from Ready For Testing to Closed

#8 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/6429 added

#9 Updated by The Foreman Bot 10 months ago

  • Pull request https://github.com/theforeman/foreman/pull/6436 added

Also available in: Atom PDF