Project

General

Profile

Refactor #25896

Syslog logging pattern should not include time or request id

Added by Lukas Zapletal about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Lukas Zapletal
Category:
Logging
Target version:
-
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6428
Fixed in Releases:
1.22.0
Found in Releases:
Red Hat JIRA:

Description

The sys_pattern was created to differentiate between file appender and syslog appender:

:pattern: "%d [%.1l|%.3c|%.8X{request}] m\n" 
  :sys_pattern: "[.1l|%.3c|%.8X{request}] %m\n"

It does not make sense to have the same defaults for both, syslog should really be just %m (message itself), all the rest can be added in syslog configuration when needed.

Related issues

Related to Foreman - Tracker #22569: Unified and structured loggingAssigned

Associated revisions

Revision 815c48c0 (diff)
Added by Lukas Zapletal about 4 years ago

Fixes #25896 - syslog pattern default is short

History

#1 Updated by Lukas Zapletal about 4 years ago

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6428 added

#3 Updated by Tomer Brisker about 4 years ago

  • Fixed in Releases 1.22.0 added

#4 Updated by Lukas Zapletal about 4 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF