Project

General

Profile

Bug #25965

Missing timeout for "Actions::Katello::Host::Package::Update" task

Added by Christine Fouant over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Hosts
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1651852

Description of problem:
If gofer of the patching client is not connecting to the Satellite, the Actions::Katello::Host::Package::Update task will wait forever.

The expect behaviour is to wait 20 seconds and timeout if gofer then respond just like "Actions::Katello::Host::Package::Install" task

Adding this seems should work.

--- /opt/theforeman/tfm/root/usr/share/gems/gems/katello-3.7.0.41/app/lib/actions/pulp/consumer/content_update.rb 2018-11-21 15:08:02.227949116 1100
+
+ /tmp/content_update.rb 2018-11-21 15:07:31.069169127 +1100
@ -15,10 +15,12 @
options = { "importkeys" => true }
options[:all] = true if input[:args].blank?

- pulp_extensions.consumer.update_content(input[:consumer_uuid],
+ task = pulp_extensions.consumer.update_content(input[:consumer_uuid],
input[:type],
parse_units_for_type,
options)
+ schedule_timeout(Setting['content_action_accept_timeout'])
+ task
end

Actual results:
Task "Waiting for Pulp" forever

Expected results:
Task failed with:
Host did not respond within 20 seconds. The task has been cancelled. Is katello-agent installed and goferd running on the Host?

Associated revisions

Revision 7949d971 (diff)
Added by Christine Fouant over 3 years ago

fixes #25965 - adds timeout to consumer update

History

#1 Updated by The Foreman Bot over 3 years ago

  • Assignee set to Christine Fouant
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7955 added

#2 Updated by Christine Fouant over 3 years ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Justin Sherrill over 3 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.12.0

Also available in: Atom PDF