Project

General

Profile

Bug #2599

Checkboxes on Import environments form should default to unchecked

Added by Mikael Fridh over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Importers
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Since destroying entire environments is a destructible action - make what to act on here explicit instead of defaulting to change all. Imagine accidentally clicking Submit on a Foreman server with 500 environments and the action says Delete: on all 500 of them.

env_import.ogg env_import.ogg 658 KB Env Import GUI demo Mikael Fridh, 06/03/2013 08:21 AM

Associated revisions

Revision d9cbe8a3 (diff)
Added by Mikael Fridh over 7 years ago

fixes #2599 - Bulk-selectable environments & puppet classes import

Makes the Env/Classes import a bit safer by first of all defaulting all the
checkboxes to be unchecked. Also adds multiple toggle links to selectively
realize All/New/Changed/Obsolete puppet modules.

History

#1 Updated by Mikael Fridh over 7 years ago

  • % Done changed from 0 to 50

#2 Updated by Mikael Fridh over 7 years ago

Mikael Fridh wrote:

https://github.com/theforeman/foreman/pull/674

Pull request updated. I now default to unchecked, but added a "Select all" box on top and changed the title. (Needs translation).

#3 Updated by Dominic Cleal over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee changed from Ohad Levy to Mikael Fridh
  • Target version changed from 1.2.0 to 1.3.0

#4 Updated by Mikael Fridh over 7 years ago

Did some more testing and found header links looked a bit odd in some cases (shifted too far right). Shipped another commit to the pullreq. Functionally everything seems fine.

#5 Updated by Mikael Fridh over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 50 to 100

Also available in: Atom PDF