Project

General

Profile

Actions

Refactor #260

closed

Switch family implemetation to use STI

Added by Paul Kelly over 14 years ago. Updated over 14 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

The home grown class inheritance stuff in family is confusing.
Switch to using a set of classes based upon the Operatingsystem


Related issues 1 (0 open1 closed)

Blocks Foreman - Feature #178: Automate populating the TFTP directoryClosedPaul Kelly03/14/2010Actions
Actions #1

Updated by Paul Kelly over 14 years ago

  • Status changed from New to Feedback
  • Branch set to refactor/260-family-with-sti
Actions #2

Updated by Paul Kelly over 14 years ago

By adding a 'type' field to the operatingsystem record and then managing this field manually we can make Rails cast the record to the required family class.

Actions #3

Updated by Ohad Levy over 14 years ago

  • Target version set to 0.1-6
Actions #4

Updated by Paul Kelly over 14 years ago

Fixed for 1.5
Tests work

Actions #5

Updated by Paul Kelly over 14 years ago

Added OS before_filter to deduce the family, if not set
OS DB entries can now contain a null type
@@families promoted to Operatingsystem::FAMILIES
Included mods suggested by Ohad

Actions #6

Updated by Paul Kelly over 14 years ago

Rebased
Centralized Family name and os membership list into a single hash
Added test in unattended controller that detects if a os has no family
simplified deduce_family
tests pass

Actions #7

Updated by Paul Kelly over 14 years ago

  • Status changed from Feedback to Ready For Testing
  • % Done changed from 0 to 100
Actions #8

Updated by Ohad Levy over 14 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF