Project

General

Profile

Bug #26052

Vertical navigation missing IDs

Added by Walden Raines over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Gilad Lekner
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
1647482
Pull request:
https://github.com/theforeman/foreman/pull/6770, https://github.com/theforeman/foreman/pull/6551
Fixed in Releases:
1.23.0
Found in Releases:
Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1647482

Description of problem:
Missing HTML IDs (at least) in Vertical Navigation. Regression against 6.4.

Version-Release number of selected component (if applicable):
Sat 6.5 snap 1

How reproducible:
Deterministic

Steps to Reproduce:
1. Login the Satellite
2. On the homepage, inspect Vertical Navigation's HTML

Actual results:
The tags don't have ID specified

Expected results:
The tags should have ID specified (preferrably the same as in Sat 6.4)

Related issues

Related to Foreman - Task #23445: Change vertical menu to react implementationClosed
Related to foreman-tasks - Bug #26827: Tasks menu has divider with no nameClosed
Related to Foreman - Refactor #28938: add id to menu top level itemsNew

Associated revisions

Revision 68bda9e1 (diff)
Added by Gilad Lekner about 4 years ago

fixes #26052 - navigation missing IDs

Revision bfce9f2d (diff)
Added by Tomer Brisker about 4 years ago

Refs #26052 - skip menu items with no name

Not all menu items have a name, but patternfly-react requires names and
various attributes (such as id) assume the name is present.
This filters out any items with no name.
The selector has also been refactored a bit, to use `.map` instead of
`.forEach` and extracted the children logic to as seperate function.

History

#1 Updated by Walden Raines over 4 years ago

  • Assignee changed from Ohad Levy to Gilad Lekner

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6551 added

#3 Updated by Tomer Brisker about 4 years ago

  • Related to Task #23445: Change vertical menu to react implementation added

#4 Updated by Tomer Brisker about 4 years ago

  • Fixed in Releases 1.23.0 added

#5 Updated by Anonymous about 4 years ago

  • Status changed from Ready For Testing to Closed

#6 Updated by The Foreman Bot about 4 years ago

  • Pull request https://github.com/theforeman/foreman/pull/6770 added

#7 Updated by Tomer Brisker about 4 years ago

  • Related to Bug #26827: Tasks menu has divider with no name added

#8 Updated by Tomer Brisker over 3 years ago

Also available in: Atom PDF