Bug #26071
Refactor Higher Order Components for Check Organization component (React)
Status:
New
Priority:
Normal
Assignee:
Category:
Organizations and Locations
Target version:
Description
This comes from this discussion https://github.com/Katello/katello/pull/7954#discussion_r256451637
We would like to keep the CheckOrg component snapshot 'disconnected' from Redux to make smaller and more manageable snapshots.
This could be done with a HOC, which is suggested in the discussion. I started with an implementation for this but was blocked by some issues, so this is a follow up to investigate this more (and not block the PR)
There may be additional improvements in this area around the HOCs. Redux has a compose method that could be used to 'stack' HOCs on a component https://redux.js.org/api/compose
My try is in https://github.com/johnpmitsch/katello/commit/5b746864d65f764e1b8b25c7dcf9f68817b5ae10
History
#1
Updated by John Mitsch over 3 years ago
- Assignee deleted (
Thomas McKay)
#2
Updated by Chris Roberts about 3 years ago
- Triaged changed from No to Yes
- Assignee set to John Mitsch