Project

General

Profile

Refactor #261

switch parameters to use a single reference id

Added by Paul Kelly about 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Parameters use multiple id fields to refer to their associated object. This is not required.

Associated revisions

Revision aa1796f3 (diff)
Added by Paul Kelly almost 10 years ago

Fixes #261 - parameters now use a single reference_id

This implementation uses STI but the table looks the same for all
variants. This is a little strange but it seems to work.

Also removed obsolete controllers and tests
Added more tests

History

#1 Updated by Paul Kelly about 10 years ago

  • Subject changed from switch parameters to use STI to switch parameters to use a single reference id

#2 Updated by Paul Kelly about 10 years ago

  • Category set to Rails
  • Status changed from New to Assigned

Ohad, I am unclear as to whether I have misunderstood your parameters implementation.
There are host parameters for all hosts for these keys ["hostmode", "hosttype", "longsitename", "puppetmaster", "sitename"]. Are these left over from an experiment or are we migrating to use these as the source of that information. I would also expect some of these to be domainparameters.

#3 Updated by Paul Kelly about 10 years ago

  • Status changed from Assigned to Feedback
  • Branch set to refactor/261-parameters-use-reference_id

Rebased against develop
Tests pass.

#4 Updated by Paul Kelly about 10 years ago

Refactored concrete class validations back into the abstract base class.
Removed obsolete controllers and their tests
Fixed some tests so as to always use a concrete class
Tests pass

#5 Updated by Ohad Levy almost 10 years ago

  • Target version set to 0.1-6

#6 Updated by Paul Kelly almost 10 years ago

Rebased
Fixed bug where hosts were marked :dependent => :destroy. Ouch!

#7 Updated by Paul Kelly almost 10 years ago

There were issues with the uniqueness constraint that are now fixed.
Added some tests, to be sure.

#8 Updated by Paul Kelly almost 10 years ago

  • Status changed from Feedback to Ready For Testing
  • % Done changed from 0 to 100

#9 Updated by Ohad Levy almost 10 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF