Project

General

Profile

Bug #26100

Remove foreman_organization/location from taxonomy detection and add tests

Added by Lukas Zapletal 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
High
Category:
-
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Puppet importer taxonomy code (set_taxonomies) is causing problems for discovery, this is a regression. We had no tests for this in discover and that's the reason why this was easy to introduce. This is the timeline:

- Bug in older version of Foreman
- Fix in Foreman 1.14
- Regression in Foreman 1.17
- Fix no. 2 merged for Foreman 1.22

Fix:
https://github.com/theforeman/foreman/commit/c49eb07f93f6821d7a7cad518ef537cd9ca41478

Regression:
https://github.com/theforeman/foreman/commit/715d097cbd058d171c8a2c65ad5d519d128d1123

Fix 2:
https://github.com/theforeman/foreman/pull/6478

This patch adds more tests around taxonomy and makes sure that taxonomy does not gets overriden by core importing taxonomy setting mechanism again. In order to make the tests effective, this patch also removes "foreman_organization" and "foreman_location" taxonomy detection, this can be easily changed by users to the same fact but with different name: "discovery_organization" and "discovery_location".


Related issues

Related to Foreman - Bug #26038: Puppet importer refactoring changed taxonomy flowClosed

Associated revisions

Revision be73dfd1 (diff)
Added by Lukas Zapletal 6 months ago

Fixes #26100 - drop foreman_organization and tests

History

#1 Updated by Lukas Zapletal 6 months ago

  • Bugzilla link set to 1679481

#2 Updated by Lukas Zapletal 6 months ago

  • Related to Bug #26038: Puppet importer refactoring changed taxonomy flow added

#3 Updated by The Foreman Bot 6 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/471 added

#4 Updated by Anonymous 6 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF