Project

General

Profile

Bug #26113

Smart proxy log times not displayed.

Added by Alex Fisher over 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomer Brisker
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6511
Fixed in Releases:
1.21.0
Found in Releases:
1.21.0

Description

Foreman and smart-proxy version: 1.21.0-RC5

Log entries are not displaying timestamps.
Screenshot

missing-times.png View missing-times.png 98.5 KB Screenshot Alex Fisher, 02/22/2019 11:12 AM
Missing times

Related issues

Related to Foreman - Feature #19047: Unify the way how we display datesClosed2017-03-28
Related to Foreman - Feature #21312: Foreman should provide react components for formatting datesClosed
Has duplicate Foreman - Bug #25982: Smart Proxy | Time column in logs view is emptyDuplicate

Associated revisions

Revision 8da0a865 (diff)
Added by Tomer Brisker over 3 years ago

Fixes #26113 - Show timestamp in proxy log pane

When unifing the date time columns, the datatables initializer for the
logs table was changes to render the time column as it is. This does not
work properly with the new react date component, causing the column to
be empty. This commit removes the unneeded render function for this
column and corrects the helper to also display seconds for the
timestamps.

History

#1 Updated by Ewoud Kohl van Wijngaarden over 3 years ago

  • Category set to Web Interface
  • Found in Releases 1.21.0 added

#2 Updated by Ewoud Kohl van Wijngaarden over 3 years ago

  • Triaged changed from No to Yes

#3 Updated by Tomer Brisker over 3 years ago

Digging in to this, looks like the datatable is initialized before react renders the date component, causing the component to be rendered off-screen for some reason. I'm continuing to investigate.

#4 Updated by Tomer Brisker over 3 years ago

#5 Updated by The Foreman Bot over 3 years ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6511 added

#6 Updated by Ohad Levy over 3 years ago

  • Target version set to 1.22.0
  • Fixed in Releases 1.22.0 added

#7 Updated by Tomer Brisker over 3 years ago

  • Fixed in Releases 1.21.0 added
  • Fixed in Releases deleted (1.22.0)

#8 Updated by Tomer Brisker over 3 years ago

  • Status changed from Ready For Testing to Closed

#9 Updated by Ondřej Ezr over 3 years ago

  • Has duplicate Bug #25982: Smart Proxy | Time column in logs view is empty added

#10 Updated by Tomer Brisker over 3 years ago

  • Related to Feature #21312: Foreman should provide react components for formatting dates added

#11 Updated by Tomer Brisker about 3 years ago

  • Target version deleted (1.22.0)

#12 Updated by The Foreman Bot almost 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/7939 added

Also available in: Atom PDF