Project

General

Profile

Bug #26199

Using server_git_repo in theforeman-puppet leads to a dependency cycle

Added by Ewoud Kohl van Wijngaarden 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Foreman modules
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Found in Releases:

Description

dependency cycles found: (File[/opt/puppetlabs/puppet/cache] => Class[Puppet::Server::Install] => Class[Puppet::Server::Config] => File[/opt/puppetlabs/puppet] => File[/opt/puppetlabs/puppet/cache])

Associated revisions

Revision 964f110c (diff)
Added by Ewoud Kohl van Wijngaarden 3 months ago

Fixes #26199 - Fix dependency cycle when using git_repo

Previously this resulted in a dependency cycle. The tests didn't compile
so didn't catch it.

dependency cycles found: (File[/opt/puppetlabs/puppet/cache] => Class[Puppet::Server::Install] => Class[Puppet::Server::Config] => File[/opt/puppetlabs/puppet] => File[/opt/puppetlabs/puppet/cache])

a61e010e8d24f2e44ab1ebba0cc4382b05ce9d37 introduced this by managing
$sharedir in puppet::server::config. $vardir was managed in
puppet::server::install. Since sharedir is actually
/opt/puppetlabs/puppet and vardir is the cache directory within that, it
created a cycle.

History

#1 Updated by The Foreman Bot 3 months ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/puppet-puppet/pull/682 added

#2 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Ewoud Kohl van Wijngaarden 3 months ago

  • Fixed in Releases 1.22.0 added

#4 Updated by Tomer Brisker about 2 months ago

  • Fixed in Releases 1.21.1 added

Also available in: Atom PDF