Bug #26232
Override Values API - request fails if the matcher attribute name has space or dot(.) character
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Description
From BZ:
Steps:
1. Attempt to update the override value by PUTing on satellite with overrides matcher instead of its id. e.g:- curl -u admin:changeme -X PUT -d '{"value":"overridened3"}' --header "Content-Type:application/json" "https://<server_url>/api/v2/puppetclasses/1/smart_class_parameters
/3/override_values/os=rhel7.6"
Observation and Logs:
PUT request fails if the matcher attribute name has space or dot(.) character.
- curl -X PUT -d '{"value":"overridened3"}' --header "Content-Type:application/json" "https://<server_url>/api/v2/puppetclasses/1/smart_class_parameters/3/override_values/os=rhel7.6"
{
"error": {"message":"Resource override_value not found by id 'os=rhel7'"
}
- curl
X PUT -d '{"value":"overridened3"}' --header "Content-Type:application/json" "https://<server_url>/api/v2/puppetclasses/1/smart_class_parameters/3/override_values/os=rhel 7"//IETF//DTD HTML 2.0//EN">
<!DOCTYPE HTML PUBLIC "
<html><head>
<title>400 Bad Request</title>
</head><body>
<h1>Bad Request</h1>
<p>Your browser sent a request that this server could not understand.<br />
</p>
</body></html>
Related issues
Associated revisions
History
#1
Updated by Ori Rabin about 4 years ago
Updated by - Related to Feature #22090: API Support for easier use of Smart-Class Param Overrides added
#2
Updated by The Foreman Bot about 4 years ago
Updated by - Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6538 added
#3
Updated by Marek Hulán about 4 years ago
Updated by - Fixed in Releases 1.22.0 added
#4
Updated by Ori Rabin about 4 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 38b5f738d3432d3505ac4bd6bec020e2290f622a.
Fixes #26232 - Adding id contraints on override_values routes (#6538)
To allow dots and spaces when the id is the matcher