Refactor #26327
deprecate allowing passing :confirm directly to link_to helper
Description
it should be passed nested inside the :data html option (https://api.rubyonrails.org/v5.2.2/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to). We currently have a workaround wrapper for that helper that changes the options to nest it under :data.
Related issues
Associated revisions
History
#1
Updated by Tomer Brisker about 4 years ago
Updated by - Related to Bug #7574: update confirm option for the link_to helper to be data attribute for rails 4 upgrade added
#2
Updated by The Foreman Bot about 4 years ago
Updated by - Assignee set to Tomer Brisker
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/6563 added
#3
Updated by Timo Goebel about 4 years ago
Updated by - Fixed in Releases 1.22.0 added
#4
Updated by Tomer Brisker about 4 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset 01a3308ddf46b6ee04be460d9aa9a913adadb574.
#5
Updated by Anonymous almost 4 years ago
- Related to Refactor #26929: stop using deprecated :confirm usage added
Fixes #26327 - Deprecate confirm option in link_to helper
This was introduced as a workaround when upgrading to rails 4 and stayed
around since then. It's about time we stop supporting it and start using
the rails 4+ way.