Project

General

Profile

Refactor #26327

deprecate allowing passing :confirm directly to link_to helper

Added by Tomer Brisker 9 months ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

it should be passed nested inside the :data html option (https://api.rubyonrails.org/v5.2.2/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to). We currently have a workaround wrapper for that helper that changes the options to nest it under :data.


Related issues

Related to Foreman - Bug #7574: update confirm option for the link_to helper to be data attribute for rails 4 upgradeClosed2014-09-22
Related to OpenSCAP - Refactor #26929: stop using deprecated :confirm usageClosed

Associated revisions

Revision 01a3308d (diff)
Added by Tomer Brisker 9 months ago

Fixes #26327 - Deprecate confirm option in link_to helper

This was introduced as a workaround when upgrading to rails 4 and stayed
around since then. It's about time we stop supporting it and start using
the rails 4+ way.

History

#1 Updated by Tomer Brisker 9 months ago

  • Related to Bug #7574: update confirm option for the link_to helper to be data attribute for rails 4 upgrade added

#2 Updated by The Foreman Bot 9 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6563 added

#3 Updated by Timo Goebel 9 months ago

  • Fixed in Releases 1.22.0 added

#4 Updated by Tomer Brisker 9 months ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Michael Moll 6 months ago

Also available in: Atom PDF