Project

General

Profile

Actions

Refactor #26327

closed

deprecate allowing passing :confirm directly to link_to helper

Added by Tomer Brisker over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
easy
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

it should be passed nested inside the :data html option (https://api.rubyonrails.org/v5.2.2/classes/ActionView/Helpers/UrlHelper.html#method-i-link_to). We currently have a workaround wrapper for that helper that changes the options to nest it under :data.


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #7574: update confirm option for the link_to helper to be data attribute for rails 4 upgradeClosedTom Caspy09/22/2014Actions
Related to OpenSCAP - Refactor #26929: stop using deprecated :confirm usageClosedActions
Actions #1

Updated by Tomer Brisker over 5 years ago

  • Related to Bug #7574: update confirm option for the link_to helper to be data attribute for rails 4 upgrade added
Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/6563 added
Actions #3

Updated by Timo Goebel over 5 years ago

  • Fixed in Releases 1.22.0 added
Actions #4

Updated by Tomer Brisker over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Anonymous over 5 years ago

Actions

Also available in: Atom PDF