Project

General

Profile

Actions

Feature #26362

closed

Update fog-openstack to 1.0.8

Added by Lukas Zapletal over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Compute resources - OpenStack
Target version:
-
Difficulty:
easy
Triaged:
Yes
Fixed in Releases:
Found in Releases:

Description

This looks like a smooth upgrade, nothing major changed and everything seem to work. However, there is one slight detail - fog-openstack URL is not versionless, therefore it must not contain any path part (/v2 or /v3) as the API code determines the version from the other fields. This is the upstream change:

Keystone endpoints are version less. Version 3 is the default as v2.0 is deprecated. Meanwhile Keystone V3 still supports v2.0 for backward compatibility. Therefore passing a tenant instead of a project (along with a domain) makes Keystone provide v2.0 token.

This does not work nicely with Foreman when Tenants are not known (before Load tenants button is pressed), therefore the easiest solution is to enforce users to select V2 or V3. Instead adding new flag, I propose easier approach which will be also upgrade-friendly - Compute Resource model now validates if URL contains /v2 or /v3 and this is used to pick either v2.0 or v3 protocol. Users already have paths so this will work transparently for them.


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #25956: fog-libvirt 0.6 renames all modules/classesClosedJustin SherrillActions
Related to Foreman - Bug #26971: unintialized Constant in app/models/compute_resources/foreman/model/openstack.rbClosedActions
Actions #1

Updated by Lukas Zapletal over 5 years ago

  • Related to Bug #25956: fog-libvirt 0.6 renames all modules/classes added
Actions #2

Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6574 added
Actions #3

Updated by Marek Hulán over 5 years ago

  • Fixed in Releases 1.22.0 added
Actions #4

Updated by Lukas Zapletal over 5 years ago

  • Status changed from Ready For Testing to Closed
Actions #5

Updated by Tomer Brisker over 5 years ago

  • Related to Bug #26971: unintialized Constant in app/models/compute_resources/foreman/model/openstack.rb added
Actions

Also available in: Atom PDF