Project

General

Profile

Bug #26363

tracer plugin to yum/dnf prevents yum/dnf from working if tracer is broken

Added by Evgeni Golov over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
easy
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I've been playing with tracer on EL8 and due to a bad dependency, Tracer itself was not functioning:

>>> import tracer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/tracer/__init__.py", line 3, in <module>
    from tracer.query import Query
  File "/usr/lib/python3.6/site-packages/tracer/query.py", line 19, in <module>
    from tracer.resources.tracer import Tracer
  File "/usr/lib/python3.6/site-packages/tracer/resources/tracer.py", line 29, in <module>
    from tracer.resources.applications import Applications, AffectedApplication
  File "/usr/lib/python3.6/site-packages/tracer/resources/applications.py", line 21, in <module>
    from bs4 import BeautifulSoup, element
  File "/usr/lib/python3.6/site-packages/bs4/__init__.py", line 30, in <module>
    from .builder import builder_registry, ParserRejectedMarkup
  File "/usr/lib/python3.6/site-packages/bs4/builder/__init__.py", line 308, in <module>
    from . import _htmlparser
  File "/usr/lib/python3.6/site-packages/bs4/builder/_htmlparser.py", line 7, in <module>
    from html.parser import (
ImportError: cannot import name 'HTMLParseError'

While this was my own fault, I've tried to kick tracer from my system:

[root@rhel-8-nightly ~]# yum erase katello-host-tools-tracer
Error Importing tracer! Is tracer installed?
[root@rhel-8-nightly ~]#

I don't think the plugin we ship should prevent yum from working?

Droping sys.exit from /usr/lib/python3.6/site-packages/katello/tracer.py was sufficient to fix that issue.

Associated revisions

Revision 41f59686 (diff)
Added by Jonathon Turel over 2 years ago

Fixes #26363 - Don't exit transaction when tracer is broken

History

#1 Updated by Evgeni Golov over 2 years ago

  • Description updated (diff)

#2 Updated by Jonathon Turel over 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.12.0

#3 Updated by Jonathon Turel over 2 years ago

  • Assignee set to Jonathon Turel

#4 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello-host-tools/pull/94 added

#5 Updated by Jonathon Turel over 2 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF