Project

General

Profile

Bug #26380

webpack:compile rake task is executed twice

Added by Tomer Brisker over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rake tasks
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

This is because webpack-rails gem also defines the same task, causing the action to run twice.


Related issues

Related to Foreman - Bug #25778: Assets compilation failure on Jenkins+Remote Execution/Ansible due to "Allocation failed - JavaScript heap out of memory"Closed

Associated revisions

Revision 462685d9 (diff)
Added by Tomer Brisker over 1 year ago

Fixes #26380 - Only execute webpack:compile task once

webpack-rails gem defines a task with the same name, causing the task to
be registered twice and thus executed twice. The task file in our code
has been renamed so it registers after the gem's task and clears the
previously registered task before registering our version.

This should save about 3 minutes per jenkins run, and also speed up
running tests locally.

History

#1 Updated by Tomer Brisker over 1 year ago

  • Related to Bug #25778: Assets compilation failure on Jenkins+Remote Execution/Ansible due to "Allocation failed - JavaScript heap out of memory" added

#2 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6581 added

#3 Updated by Ohad Levy over 1 year ago

  • Target version set to 1.22.0
  • Fixed in Releases 1.22.0 added

#4 Updated by Tomer Brisker over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF