Bug #2640
closed
Sign out button is missing protocol
Description
On 1.2RC2
Sign out url is missing the protocol prefix (http or https).
This causes logout to fail when logged in on https and foreman is unavailable on http.
Updated by Dominic Cleal over 11 years ago
I don't this here, the link has a full URL including protocol. What appears in the link - only the path, only the hostname onwards?
Updated by Taylan Develioglu over 11 years ago
fqdn/users/logout
the my account link, for example, is https://fqdn/users/...
Updated by Marek Hulán over 11 years ago
- Status changed from New to Assigned
I can't reproduce. Also nothing in code suggests any nonstandard behavior. However this may be related to your setup if you're running foreman behind proxy. Rails detects HTTPS request behind proxy by various custom headers that your proxy probably does not attach. Make sure you are adding 'X-Forwarded-Proto: https' header correctly.
Although this is not entirely a bug we could change logout_users_url which generates absolute path to logout_users_path which generates only the relative part. This will fix the issue for users with wrongly configured proxy.
Updated by Marek Hulán over 11 years ago
- Status changed from Assigned to Ready For Testing
Updated by Taylan Develioglu over 11 years ago
You are correct, we are running foreman behind proxy and the header is not added.
Updated by Dominic Cleal over 11 years ago
Would you mind giving the (very small) patch a try? Looks like it'll work to me.
Updated by Taylan Develioglu over 11 years ago
Yes, I tried it and it's fixed. The signout url now has https in it.
Updated by Marek Hulán over 11 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 1ff6a50c16ef6e8bf8b1aa709ec2f8769ba70d79.