Project

General

Profile

Bug #26441

Default value for date column not set to React component

Added by Ondřej Ezr about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Ezr
Category:
JavaScript stack
Target version:
-
Difficulty:
trivial
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/6617
Fixed in Releases:
1.21.1, 1.22.0
Found in Releases:

Description

We are calling the mounter in application_helper using:

# NOTE the default: _('N/A') part
mount_react_component(component, "##{date_id}", { date: time.try(:iso8601), default: _('N/A'), seconds: seconds }.to_json, { :flatten_data => true })

But all the components are expecting `defaultValue` instead.

Related issues

Related to Foreman - Feature #21312: Foreman should provide react components for formatting datesClosed

Associated revisions

Revision e012ca97 (diff)
Added by Ondřej Ezr about 2 years ago

Fixes #26441 - default value for React datetime

History

#1 Updated by The Foreman Bot about 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6617 added

#2 Updated by Ondřej Ezr about 2 years ago

  • Status changed from Ready For Testing to Closed

#3 Updated by Tomer Brisker about 2 years ago

#4 Updated by Tomer Brisker about 2 years ago

  • Related to Feature #21312: Foreman should provide react components for formatting dates added

#5 Updated by Tomer Brisker about 2 years ago

  • Related to deleted (Feature #19047: Unify the way how we display dates)

#6 Updated by Tomer Brisker about 2 years ago

  • Fixed in Releases 1.21.1, 1.22.0 added

Also available in: Atom PDF