Project

General

Profile

Bug #26478

Remove dead code on pulp-2.19 upgrade

Added by Partha Aji over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Repositories
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

https://github.com/Katello/katello/blob/master/app/services/katello/pulp/repository.rb#L241-L252

        if content_type == ::Katello::Erratum::CONTENT_TYPE
          # copy the modules belonging to this errarta over (pulp 2.19 should handle this case out of the box)
          # remove this code after 2.19
          module_stream_ids = units.map do |erratum|
            erratum.module_stream_objects.map(&:pulp_id)
          end
          module_stream_ids.flatten!
          smart_proxy.pulp_api.extensions.module.copy(repo.pulp_id,
                                                      destination_repo.pulp_id,
                                                      ids: module_stream_ids,
                                                      override_config: override_config)
        end

Needs to get removed when pulp 2.19 upgrade happens

Associated revisions

Revision dc8776cf (diff)
Added by Partha Aji over 2 years ago

Fixes #26478 - Remove unnecessary module copy (#8072)

Pulp 2.19 automatically copies modules on errata copy during incremental
update. The copy code is not necessary anymore. This commit aims to
achieve that.

History

#1 Updated by Jonathon Turel over 2 years ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.12.0

#2 Updated by The Foreman Bot over 2 years ago

  • Assignee set to Partha Aji
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/8072 added

#3 Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF