Project

General

Profile

Bug #26562

Queries::SmartProxyQueryTest failure with Rails 5.2.2

Added by Anonymous over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tests
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

Starting with https://github.com/rails/rails/commit/3a2e893b89fb5b352ef749a9c4befec323ce24e8

Queries::SmartProxyQueryTest#test_0001_fetching smart proxy attributes:
NoMethodError: undefined method `[]' for nil:NilClass
    test/graphql/queries/smart_proxy_query_test.rb:38:in `block in <class:SmartProxyQueryTest>'

Related issues

Blocks Foreman - Tracker #25601: Rails 5.2.4 trackerRejected

Associated revisions

Revision d25f7031 (diff)
Added by Tomer Brisker 12 months ago

Fixes #26562 - Test smart proxy graphql on hosts with env

Due to a change in Rails (https://github.com/rails/rails/pull/33673/),
when factory bot creates a smart proxy with child hosts it now triggers
a save on the hosts, which in this test fails because hosts validate
that they have an environment set if they have a puppet proxy assigned.

History

#1 Updated by Anonymous over 1 year ago

#2 Updated by Anonymous over 1 year ago

#3 Updated by Anonymous over 1 year ago

#4 Updated by The Foreman Bot over 1 year ago

  • Assignee set to Anonymous
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6664 added

#5 Updated by Anonymous over 1 year ago

  • Category set to Tests

#6 Updated by Anonymous over 1 year ago

  • Assignee deleted (Anonymous)
  • Status changed from Ready For Testing to New

#7 Updated by The Foreman Bot 12 months ago

  • Assignee set to Tomer Brisker
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/7166 added

#8 Updated by The Foreman Bot 12 months ago

  • Fixed in Releases 2.0.0 added

#9 Updated by Tomer Brisker 12 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF