Bug #26581: Improve Layout active MenuItems performance - Foreman

Actions

Copy link

Bug #26581

closed

Improve Layout active MenuItems performance

Added by Gilad Lekner over 5 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Gilad Lekner

Category:

Web Interface

Target version:

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/6672

Fixed in Releases:

1.23.0

Found in Releases:

Red Hat JIRA:

Description

Since PF VerticalNav component receives a `activePath` prop, there is no need to handle the active state of each Menu Item inside the items array.
This should also improve performance because there is no need to iterate through the items after each navigation.