Project

General

Profile

Actions

Bug #26581

closed

Improve Layout active MenuItems performance

Added by Gilad Lekner about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Fixed in Releases:
Found in Releases:

Description

Since PF VerticalNav component receives a `activePath` prop, there is no need to handle the active state of each Menu Item inside the items array.
This should also improve performance because there is no need to iterate through the items after each navigation.

Actions #1

Updated by The Foreman Bot about 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6672 added
Actions #2

Updated by Anonymous almost 5 years ago

  • Fixed in Releases 1.23.0 added
Actions #3

Updated by Anonymous almost 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF