Project

General

Profile

Bug #26581

Improve Layout active MenuItems performance

Added by Gilad Lekner 8 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Since PF VerticalNav component receives a `activePath` prop, there is no need to handle the active state of each Menu Item inside the items array.
This should also improve performance because there is no need to iterate through the items after each navigation.

Associated revisions

Revision b275ba86 (diff)
Added by Gilad Lekner 7 months ago

Fixes #26581 - Improve Layout active MenuItems performance

History

#1 Updated by The Foreman Bot 8 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/6672 added

#2 Updated by Michael Moll 7 months ago

  • Fixed in Releases 1.23.0 added

#3 Updated by Anonymous 7 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF