Project

General

Profile

Feature #26591

Raise minimum Puppet version to 4.4

Added by Ewoud Kohl van Wijngaarden about 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ewoud Kohl van Wijngaarden
Category:
Puppet
Target version:
Foreman - 1.23.0
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/theforeman/smart-proxy/pull/686, https://github.com/theforeman/smart-proxy/pull/666, https://github.com/theforeman/smart-proxy/pull/637
Fixed in Releases:
Foreman - 1.23.0
Found in Releases:
Red Hat JIRA:

Description

Currently there's still a lot of code to support Puppet 3, but that's EOL. There's also some code for early 4.x versions that nobody should be using anymore. 4.4+ doesn't need any special version handling so that'll be the minimum new version.

Related issues

Related to Installer - Refactor #27053: Drop Puppet 3 support from the proxyClosed
Related to Smart Proxy - Refactor #30855: Drop unused Puppet test fixturesClosed
Related to Smart Proxy - Refactor #30857: Merge Puppet Proxy Puppet API provider code into the Puppet moduleReady For Testing

Associated revisions

Revision 5b1f39cd (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Refs #26591 - Improve BMC logging output

Revision 04f03762 (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Refs #26591 - Optimize Proxy::Bmc.installed?

Revision 08a556c2 (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Refs #26591 - Stub Rubyipmi.is_provider_installed?

With the removal of the Puppet gem, it looks like /sbin is no longer
guaranteed to be in PATH. Since these tests shouldn't care about that,
we can pretend by stubbing.

Revision 7e7015ab (diff)
Added by Ewoud Kohl van Wijngaarden almost 4 years ago

Fixes #26591 - Remove puppet_proxy_legacy (Puppet 3)

This drops legacy Puppet support and relies on the Puppet API to
retrieve classes. This means at least Puppet 4.4 is required. Since
Puppet 4 also removed puppet kick, that provider is removed as well.

Revision a3a98f6e (diff)
Added by Evgeni Golov almost 4 years ago

Refs #26591 - don't try to load puppet_proxy_legacy anymore

Revision c6a06580 (diff)
Added by Ewoud Kohl van Wijngaarden over 3 years ago

Refs #26591 - Drop unused ResourceTypeApiv3

7e7015aba068db541bd4f4cf1856bf69ebbe2953 removed the legacy Puppet
implementation but left an unused ResourceTypeApiv3 class.

History

#1 Updated by The Foreman Bot about 4 years ago

  • Assignee set to Ewoud Kohl van Wijngaarden
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/637 added

#2 Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

#3 Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Triaged changed from No to Yes
  • Fixed in Releases 1.23.0 added

#4 Updated by Ewoud Kohl van Wijngaarden almost 4 years ago

  • Status changed from Ready For Testing to Closed

#5 Updated by The Foreman Bot almost 4 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/666 added

#6 Updated by The Foreman Bot over 3 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/686 added

#7 Updated by Ewoud Kohl van Wijngaarden over 2 years ago

#8 Updated by Ewoud Kohl van Wijngaarden over 2 years ago

  • Related to Refactor #30857: Merge Puppet Proxy Puppet API provider code into the Puppet module added

Also available in: Atom PDF