Project

General

Profile

Actions

Refactor #2660

closed

Setting model, improve tests, string parsing and change to create!

Added by Dominic Cleal over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Refactor relating to #2343:

  • added string settings type
  • fixed tests previously commented out due to CI failures
  • more tests for core settings functionality
  • parsing of string values enhanced and extracted to a separate method
  • setting value to nil when it equals default is back
  • create! is now prefered method for creating settings as it raises exceptions on invalid states

https://github.com/theforeman/foreman/pull/637


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #2343: app/models/setting.rb#default chokes on nil attributesClosedTomáš Strachota03/20/2013Actions
Actions #1

Updated by Anonymous over 11 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF